Skip to content

starknet_os: os resources test - add meta tx#14135

Merged
dorimedini-starkware merged 1 commit into
mainfrom
05-23-starknet_os_os_resources_test_-_add_meta_tx
Jun 7, 2026
Merged

starknet_os: os resources test - add meta tx#14135
dorimedini-starkware merged 1 commit into
mainfrom
05-23-starknet_os_os_resources_test_-_add_meta_tx

Conversation

@dorimedini-starkware

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@cursor

cursor Bot commented May 24, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches fee/gas constants, versioned OS resource tables, and OS program hash—changes affect billing and proving compatibility, though scope is test harness and constant alignment.

Overview
Adds MetaTxV0 to the OS syscall resource regression harness so its constant and calldata-linear costs are measured like Deploy.

The measuring account contract now invokes meta_tx_v0_syscall twice (empty vs one-element calldata). MetaTxV0 is removed from the unmeasurable syscall list and registered with linear factor 1. The stable deploy target’s __execute__ (and related entry points) take variable Span<felt252> so the inner meta-tx call can exercise calldata scaling; its Sierra/CASM artifacts are regenerated. Deploy syscall salts in the test contract change from 3 to 1 for deterministic addresses.

OS constants and blockifier 0.14.4 versioned constants are bumped: META_TX_V0_GAS_COST 167950 → 168550, MetaTxV0 constant n_steps 1301 → 1307, and program_hash.json OS hash updates. meta_tx syscall tests refresh expected VM steps and gas. Inner-call subtraction in the OS resources test zeroes n_memory_holes on deducted inner resources until the logger supports holes.

Reviewed by Cursor Bugbot for commit c1043a3. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware changed the base branch from 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy to graphite-base/14135 June 2, 2026 14:54

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 3 discussions and dismissed @Yoni-Starkware from a discussion.
Reviewable status: 9 of 10 files reviewed, all discussions resolved (waiting on Yoni-Starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_meta_tx branch from c27a5a3 to 5a9f77f Compare June 2, 2026 15:17
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14135 to 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy June 2, 2026 15:17
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy to graphite-base/14135 June 2, 2026 15:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_meta_tx branch from 5a9f77f to b949893 Compare June 3, 2026 07:17
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14135 to 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy June 3, 2026 07:17
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy to graphite-base/14135 June 3, 2026 07:23
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_meta_tx branch from b949893 to 7dd4dcd Compare June 3, 2026 07:51
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14135 to 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy June 3, 2026 07:51
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-22-starknet_os_os_resources_test_-_measure_linear_factor_add_deploy to graphite-base/14135 June 4, 2026 07:53

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).

Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.3_0.14.4.txt Outdated

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on yoavGrs and Yoni-Starkware).

Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.3_0.14.4.txt Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_meta_tx branch from 7dd4dcd to dcaf952 Compare June 7, 2026 07:40
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14135 to main June 7, 2026 07:40

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on yoavGrs and Yoni-Starkware).

Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.3_0.14.4.txt Outdated
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_meta_tx branch from dcaf952 to c1043a3 Compare June 7, 2026 07:50

@Yoni-Starkware Yoni-Starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jun 7, 2026
Merged via the queue into main with commit 87b5bdd Jun 7, 2026
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants